Pro_News version 3.2: Lots of Improvement

Forum dedicated to discussion of articles posted in Home page of Pro_News
Reply to topicReply to topic
Go to page  Previous  1, 2, 3, 4, 5, 6, 7, 8, 9, 10  Next 

  
28 Jul '09 Tue Jul 28, 2009 17:11    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Done the above, and added a Display in Home checkmark to Admin > Articles to see at a glance whether an Article displays in Home or not (blank = no; = yes; = home only).

Social Network html now called from a single html for all templates, and can be enabled/disabled from Admin > Config. (Choice of 2 soc_net.html template files offered - each with 42 entries! BTW, that's your lot, I'm done nabbing passing soc net links Rolling Eyes I don't even use them!!! Shocked )

So think I'm done 'cept for the paperwork ... Sad

Any more feedback from the beta before I build a release candidate?



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
29 Jul '09 Wed Jul 29, 2009 10:51    
fishingfan
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

I still am not seeing new news articles displayed.

I may of not corrected everything correctly. Is there a new beta zip file I can try out ?



fishingfan's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux,Apache2.2,mysql5,php5,dragonfly 9.2

 
 
 
 
  
29 Jul '09 Wed Jul 29, 2009 10:58    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

I'm building a new version - today or tomorrow I'd hope.

To confirm if the above issue is what is preventing new news displaying in Home, edit an article which is not displaying in Admin and see if Display in Home is set to No. Change it and see if then displays.



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
29 Jul '09 Wed Jul 29, 2009 15:18    
fishingfan
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Ah I am not seeing the Display in Home in the edit article in admin.

I take it this must be the template ?



fishingfan's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux,Apache2.2,mysql5,php5,dragonfly 9.2

 
 
 
 
  
29 Jul '09 Wed Jul 29, 2009 16:18    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Just so as we know what we're looking for - see below

What template is the Section you are posting to using?



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
29 Jul '09 Wed Jul 29, 2009 20:33    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Thanks, I noticed that some of the templates didn't have the Display in Home field. Now fixed.



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
29 Jul '09 Wed Jul 29, 2009 20:39    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

3.2.0.2RC is up!

Have at it, and provide feedback as soon as ...

TIA!



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
30 Jul '09 Thu Jul 30, 2009 07:42    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Thanks, layingback. I am the first who downloaded it. Very Happy

I will test it this weekend. Will let you know the result afterwards.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
30 Jul '09 Thu Jul 30, 2009 15:10    
fishingfan
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Absolutely awesome improvements. Templates and all issues with them in admin are fixed.

I've noticed a small bug in firefox using the supplied index2gly.html, in that you've got an unwanted closing div statement at the end of this line (removing it solves the layout issue when using additional headlines in home).

Code:
<div class="pn_padpanel"> {newshdline.hdline_addtl.U_BGCOLOR}</div>



I've added the following hacks into functions.php on lines, to allow the social bookmarking to headlines.

Line 1567

Code:
L_HDLINES' => _PNLHDLINES,
//fishingfan add social bookmarks to headlines
'G_SOCIALNET' => $pnsettings['soc_net'],
'U_SOCNETLINK' => $BASEHREF.getlink("&amp;aid=".$row['id']),
//end fishingfan add
'S_HDLINES' => _PNALL,



Line 1667

Code:
			
'S_ID' => $row['aid'],
//fishingfan add social bookmarks to additional headlines
'G_SOCIALNET' => $pnsettings['soc_net'],
'U_SOCNETLINK' => $BASEHREF.getlink("&amp;aid=".$row['id']),
//end fishingfan add
'S_ARTCOUNT' => min($artcount, $sec_arts_per_hdline),




In doing so I happened to notice that the include statement in the template for social bookmarking only allowed the bookmarks to display once on the page. To get round this was easy enough as I just pasted in my required bookmarks ( I don't use them either Laughing Rolling Eyes ) to the templates. (I'll uploaded them in templates sections to replace the others).

Lastly I've hacked functions.php again on line 907 to allow All Visitors to post articles. (Eg Anonymous posting) which though allowed in the section, was stopped here.

Code:
// Related Articles, modified by Masino Sinaga, June 22, 2009

//FishingFan - Comment out to allow anonymous posters.
		//if (!is_user()) {
		//	$cpgtpl->assign_block_vars('pn_msg', array(
		//		'S_MSG' => _PNLOGIN,
		//	));
		//	$cpgtpl->set_filenames(array('body' => 'pronews/submit.html'));
		//	$cpgtpl->display('body');
		//}
//Fishingfan And change following elseif to if.
		if ($edit == '') {[/color]



fishingfan's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux,Apache2.2,mysql5,php5,dragonfly 9.2

 
 
 
 
  
31 Jul '09 Fri Jul 31, 2009 07:55    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Item 1 indexgly.html: Thanks. Fixed. Seems to be just that 1 template.

Item 2 soc_net links in hdlines: I'd looked at adding this, but it's a problem with the display. (Plus the links seem to overwhelm the headline!) I can't fix the only appears once problem without patching DF itself (it uses include_once rather than include in template system). Only thing I can think of is to include just a link in headlines, then user clicks to see a pop-up 9a la Smilies)?

Item3 is_user: Good catch. Removed for release. This test is now redundant with new Post option for Sections. However the new Post tests need to be tightened up to fully replace it. So I guess there will be an RC2 ... I'll wait until after the weekend though, to pick up anything Masino reports.

Thanks.



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
31 Jul '09 Fri Jul 31, 2009 09:56    
fishingfan
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Item 1- I haven't spotted any other templates with errors. Though not used them all, so think it is that one.

Re Item 2 - I'm not to fussed about the include file, it's easy enough to add in the links, and prefer them to be on the page. Agree if you use all the bookmarks can overwhelm, and depends on the size of the headline.

Thanks for the info about 3 and the fast turnarounds.



fishingfan's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux,Apache2.2,mysql5,php5,dragonfly 9.2

 
 
 
 
  
3 Aug '09 Mon Aug 03, 2009 03:04    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Hi layingback,

I have been testing your Pro_News 3.2.0.1 BETA by using the DF and Pro_News clean installation.

I found some bugs below:

  • Missing "}" in line 341 cpg_inst.php file (just to remind you to add this "}" asap) .
  • I created a new section and a new category belongs to the new section, then I submitted a new article in it, everything seemed okay. But I got an error message when I went to my Home page (Pro_News as default on home page): CMS Error E:\WampServer2\www\dfpronews\includes\classes\template.php line 117: template->_tpl_load(): No file specified for handle body. The fact is: the headline news did not show up on home page at all. I use the default template: index2alb.html. I have not tested with another template. .
  • I went to Article page from admin panel and clicked the article (I had been logging in as admin and also as registered user), then the article showed up normally in mode full-article page, but when I clicked "Be First to Leave a Comment" link, I got an error message: "CMS Warning line 75: On /dfpronews/index.php?name=Pro_News&discuss=1 While executing query "INSERT INTO cms_bbtopics (topic_title, topic_poster, topic_time, forum_id, topic_status, topic_type, topic_vote, icon_id) VALUES ('Contoh Berita Pertama', , 1249237644, 1, 0, 0, 0, 0)" the following error occured: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' 1249237644, 1, 0, 0, 0, 0)' at line 1 In: E:\WampServer2\www\dfpronews\modules\Pro_News\functions.php on line: 1890". It seemed that the topic_poster value is blank or didn't have value. I compared with the previous Pro_News version, by opening the "pronews_articles" tables. In the previous version, the postby field has value the real name of user (in this case: 'Administrator'), meanwhile in this beta version, the value of the postby is '1' and not the real name of the user. I think this is the cause why the topic_poster above is blank, because in line 1877 in functions.php, it did not return the value at all!

Well, I think those three bugs above should be fixed now. I am still testing your Pro_News 3.2.0.1 BETA, and I will let you know if I found another bugs. Thanks.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
3 Aug '09 Mon Aug 03, 2009 04:09    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Let's discuss about my previous post:

  • The first bug has been fixed by adding "{" in line 341 in cpg_inst.php
  • IMHO, this is not a bug, actually, because after I re-checked the article that I submitted, it has "Display in Home" setting with value "No". After I changed it to "Yes", then the headline showed up normally. Layingback, if you don't mind, please change the default setting of "Display in Home" from "No" to "Yes". Besides that, I have checked that the default "Display in Home" setting from this section, the value is "Yes", but each time I submit article for this section, the value of this selection always "No" in Submit Article page from admin panel. Why? It should be "Yes" or at least, get the setting from its section (in this case: "Yes").
  • As I mentioned in my previous post, this error, actually, will occured after when I submitted a new article from admin panel (logged as admin and logged as registered user, also). I think the issue of this error caused by this code in admin_functions.php line 1080: $postby = (can_admin($module_name) ? can_admin($module_name) : $userinfo['username']); Since I logged as admin, then the value of $postby = 1. Do you think the code above should be like the code below? $postby = (can_admin($module_name) ? is_admin($module_name) : $userinfo['username']);

Layingback, I thought that you have fixed about it in this BETA version...? Wink

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
3 Aug '09 Mon Aug 03, 2009 15:08    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

I have the fixes for 1 & 3 included. Thanks.

Item 2 fix is fairly large, in fact I'm still working on it, and it will require a new release. As soon as possible, but it may be a few days.

Thanks for the testing feedback.



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
4 Aug '09 Tue Aug 04, 2009 09:42    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Hi Layingback,

This is the result for the test I did today:

I have installed CPGNuCalendar and then I make a connection between CPGNuCalendar with Pro_News and everything's okay.

When I submitted an article from admin panel, then the value in date field and mod_date field only contains 3 digit. For example, today, August 4, 2009, I entered the same date for Event Start and Event End, then the value for both of those fields are: 804. It should be: 20090804 for both of this fields.

Then I found in admin_functions.php in line ~2415 this code:

PHP:
$sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("", "'.$postby.'", "'.formatDateTime($clsdttime,'%G%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%G%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.$title.'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';



After I changed that code become this:

PHP:
$sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("", "'.$postby.'", "'.formatDateTime($clsdttime,'%Y%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%Y%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.$title.'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';



then the value that inserted to those both of fields of the cpgnucalendar table are correct.

I think the correct format is %Y%m%d and not %G%m%d.

I have also one suggestion. Do you think it is better that default value for Event Start and Event End in Submit Article form has the same value with the Publish Date and Withdrawal Date?

IMHO, when we submit new article, then the default value for the date is should be the same value with the date in the bottom of the form (Publish and Withdrawal Date). Besides that, this will save the submitter's time without having to select each of Even Start and End, at least because it has the default value that it should be.

Thank you very much.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
Link  QR 
Share this Printer Friendly Page  facebook   google+   linkedin   twitthis  
Show more ...
Go to page  Previous  1, 2, 3, 4, 5, 6, 7, 8, 9, 10  Next


Go to page  Previous  1, 2, 3, 4, 5, 6, 7, 8, 9, 10  Next