Debugging 3.2.2.1

LB,

Thought I'd post here rather than use PMs if that is ok..

I've installed 3.2.2.1 and the install went fine. After fixing the typo from Rusty it runs - so I've started trying some different settings. Here are initial findings...

1) The mode=home.html view looks good - it's picking up all the articles and doesn't display the ones not due to display in home. One problem seems to be the pagination where it is not setting cid - it works but is it supposed to? The pagination link is Pro_News/mode=home/sid=/cid=/page=2.html.

2) Pro_News/mode=hdln.html is all mixed up though - headlines are set to off in the home page so not sure if that messes it up although changing that setting changes nothing. Images and articles are all mixed up.

3) If I set the main config to order by article then in a section I set order by article by category the normal view is ok however, with hdln view (Pro_News/mode=hdln/sid=8.html) I only get one category displayed - the other one is not displayed at all. The SQL seems to be bringing up the c.id=11 but not the c.id=12 articles. If I set the section to display as default but the main config to articles by category by section and then look at the same page (Pro_News/mode=hdln/sid=8.html) it seems to generate two sql statements from line 1664 so it gets all categories.

I'll leave it at that for now as that appears to be the bit that needs fixing!

- rosbif

1) The mode=home.html view looks good - it's picking up all the articles and doesn't display the ones not due to display in home. One problem seems to be the pagination where it is not setting cid - it works but is it supposed to? The pagination link is Pro_News/mode=home/sid=/cid=/page=2.html.

That pagination link is ok, although it looks kinda flaky (because I never really intended Headlines to be more than 1 to 3 or 4 blocks per page, so never expected pagination to be used), it just means that no section or category selection is in force. I.e. it reads it as sid=all/cid=all.

- rosbif

2) Pro_News/mode=hdln.html is all mixed up though - headlines are set to off in the home page so not sure if that messes it up although changing that setting changes nothing. Images and articles are all mixed up.

You'll have to help me here, in what way "mixed up" - I took a look and it seems OK to me ... You wanted mode=hdln to display all articles if it wasn't the actual home page, no?

- rosbif

3) If I set the main config to order by article then in a section I set order by article by category the normal view is ok however, with hdln view (Pro_News/mode=hdln/sid=8.html) I only get one category displayed - the other one is not displayed at all. The SQL seems to be bringing up the c.id=11 but not the c.id=12 articles. If I set the section to display as default but the main config to articles by category by section and then look at the same page (Pro_News/mode=hdln/sid=8.html) it seems to generate two sql statements from line 1664 so it gets all categories.

Looks as if I may have missed a configuration pair, will take a look. Thanks.

If you look at the Pro_News/mode=hdln.html page now (I've just set the main order to by article only) you'll see the articles - so I understand that if this was the home page certain articles won't display but you'll also see (for example) that the 4th and 5th articles down (ids of 27 and 28) have the wrong image displayed.

Another one. I've just tried the batch upload feature and it's not working. When I had a file the path it shows on the list of files to upload shows the directory as c:\fakepath\etc. If you then click batch upload pictures it comes up with an error 'ERRORS Folder uploads/coppermine/albums/batch/ - DIR_NOT_EXIST '. This is in IE8. In Firefox the fakepath bit is not displayed but the error on upload is exactly the same..

Ah, the batch upload hack is probably giving you grief because I don't use the default location for coppermine. I don't like mixing data and code, so I move coppermine gallery in Admin > Coppermine > config.

But you've presumably got yours in default spot. But you can change the location batch upload looks for by simple edit in filesupload.php. It's on line 64, with comments. And then create the folder and it should hopefully work. Guess I should have documented that, eh?

Not had time to resolve the other 2 issues yet, I'm afraid. But the wrong image is undoubtedly use of $rowc instead of $row (or vice versa) in the code for imageholder in hdlines, due to copy-n-pasting. This is not a new error - just a previously undetected one.

Thanks - I'll have a go and let you know what works for the default. I'll keep trying different things and see if I find any others. Look forward to the getting this working!

Hope you get a chance to enjoy the holidays as well!

I've got it to work with a default placement of coppermine by changing that line to $destination = 'modules/coppermine/albums/batch/';

I then had to use FTP to make a folder called batch and put all the pictures in there. Trouble with this seems to me that by the time you use this more than once that batch folder is going to be full of pictures!

Is there any way of selecting the folder you'd like to put the pictures into? Or even to be able to create a folder on that batch upload page and upload to that?

- rosbif

I've got it to work with a default placement of coppermine by changing that line to $destination = 'modules/coppermine/albums/batch/';

Excellent. I don't want to make that the default - as it will be wrong for me. But I'll put $destination = 'modules/coppermine/albums/'; into the comment as an eg.

- rosbif

I then had to use FTP to make a folder called batch and put all the pictures in there. Trouble with this seems to me that by the time you use this more than once that batch folder is going to be full of pictures!

Well no different to using the main folder! Coppermine doesn't move photos, so the issue occurs wherever and however you upload. What I normally do is one album at a time, then coppermine just shows me the new ones.

- rosbif

Is there any way of selecting the folder you'd like to put the pictures into? Or even to be able to create a folder on that batch upload page and upload to that?

No to the first part - it is only a hack, not a module!!! But it's GPL2 Issue with making the folders on the fly is the access privileges. On some hosts they get built with right privileges, but some don't - so then it gets tricky (see prev. sentence It is still a solution to a problem which no else has solved to my knowledge. (Did you see the mods to this hack in Sponsor's forum - to make it a user batch upload?)

Well no different to using the main folder! Coppermine doesn't move photos, so the issue occurs wherever and however you upload. What I normally do is one album at a time, then coppermine just shows me the new ones.

So the batch upload will only upload from the 'batch' folder?

(Did you see the mods to this hack in Sponsor's forum - to make it a user batch upload?)

I did thanks - I think I'll leave this to admin only - my users seem to struggle viewing pages let along uploading anything!

Just tried the index2fcs-nh template and got this error:

Parse error: syntax error, unexpected '}' in public_html/includes/classes/template.php(97) : eval()'d code on line 95

Incidentally, in index2fcs-nh, how would I move the second image on the article so that it come between the intro and the article (to break it up a bit)?

Another question for you..

In headline view I can limit the number of articles to display. Is there any possibility of getting either a) a link on the bottom of each categories box to display later articles (ie pagination) or b) to let the category title be clickable to allow a link to the normal per category view (as in Pro_News/cid=12.html)?

- rosbif

So the batch upload will only upload from the 'batch' folder?

Batch upload will upload to any folder you want - just change it in the code. Remember to change it in coppermine Config too of course.

- rosbif

Just tried the index2fcs-nh template and got this error:

Parse error: syntax error, unexpected '}' in public_html/includes/classes/template.php(97) : eval()'d code on line 95

Haven't managed to track this one down as yet.

- rosbif

Incidentally, in index2fcs-nh, how would I move the second image on the article so that it come between the intro and the article (to break it up a bit)?

Make yourself a copy of the template, and in that copy just move the code, including the conditional, for IMAGE2 to the new spot. You might have to fiddle a bit to get things to display correctly/neatly. If the CSS style misbehaves, you'll have to look at any issues related to nesting of the div names - but I don't thing that will happen in the location you mention.

- rosbif

In headline view I can limit the number of articles to display. Is there any possibility of getting either a) a link on the bottom of each categories box to display later articles (ie pagination) or b) to let the category title be clickable to allow a link to the normal per category view (as in Pro_News/cid=12.html)?

Pagination would be a lot of work to apply it at Catgeory level - ie. to have more than 1 pagination sequence per page. (The UI might be a little un-user friendly too ) But adding a Category link should be easy enough just within the template (again copy it first). The link is already available (for the Catgeory Icon click) called, quite reasonably, S_CATLINK.

Thanks LB - it's about time I learnt how the templates work so I'll have a play. Have you had any luck with this one?

- layingback

- rosbif

3) If I set the main config to order by article then in a section I set order by article by category the normal view is ok however, with hdln view (Pro_News/mode=hdln/sid=8.html) I only get one category displayed - the other one is not displayed at all. The SQL seems to be bringing up the c.id=11 but not the c.id=12 articles. If I set the section to display as default but the main config to articles by category by section and then look at the same page (Pro_News/mode=hdln/sid=8.html) it seems to generate two sql statements from line 1664 so it gets all categories.

Looks as if I may have missed a configuration pair, will take a look. Thanks.

- rosbif

If you look at the Pro_News/mode=hdln.html page now (I've just set the main order to by article only) you'll see the articles - so I understand that if this was the home page certain articles won't display but you'll also see (for example) that the 4th and 5th articles down (ids of 27 and 28) have the wrong image displayed.

Seems this one has been present since per-Section default images were implemented (in 3.0?).

Here's a not very elegant solution, but it keeps the db activity low. In functions.php look for:

				if (($rowc['view'] == '0') || ($rowc['view'] == '3' && !is_user()) || (can_admin('Pro_News')) || (is_user() && (($rowc['view'] == '1') || (($rowc['view'] > 3) && (isset($userinfo['_mem_of_groups'][$rowc['view'] - 3])))))) {
					$sec_arts_per_hdline =  ($rowc['secheadlines']) ? $rowc['secheadlines'] : $arts_per_hdline;
					$sql = 'SELECT a.id aid, a.*';

and replace with:

				if (($rowc['view'] == '0') || ($rowc['view'] == '3' && !is_user()) || (can_admin('Pro_News')) || (is_user() && (($rowc['view'] == '1') || (($rowc['view'] > 3) && (isset($userinfo['_mem_of_groups'][$rowc['view'] - 3])))))) {
					$sec_arts_per_hdline =  ($rowc['secheadlines']) ? $rowc['secheadlines'] : $arts_per_hdline;
					$sql = 'SELECT a.id aid, a.*';
					if (($pnsettings['display_by'] == '0' && $rowc['secdsplyby'] == '0') || $rowc['secdsplyby'] == '0') {
						$sql .= ',s.title stitle';
					}

and for:

					if (isset($list) && $list != '' && count($list) > '0') {

						$z = 0;

						foreach ($list as $row) {

And replace by:

					if (isset($list) && $list != '' && count($list) > '0') {

						$z = 0;

						foreach ($list as $row) {
							if (($pnsettings['display_by'] == '0' && $rowc['secdsplyby'] == '0') || $rowc['secdsplyby'] == '0') {
								$rowc['stitle'] = $row['stitle'];
							}

That is append 3 new lines in both cases.

It wasn't checking _within_ the Headline block if the Section had changed, which it obviously can in Article only display.

Let me know, and on to the next (as posted above).