Some minor issues.

Hi

I've now installed the latest ProNews code on my server. I've noticed these minor issues.

My site is Fishing-Fan.co.uk

Issue #1

I've now replaced the old featured content with the FC Home template.

I saw this working perfectly on my laptop test setup, but now on the site it's flickering slightly and the "undefined" is re-appearing.

I deleted my entire sites files and uploaded my test file in zip - so they are identical.

Issue #2

If you use your SOC_NET works include on the homepage like I insanely do - the include only appears once. All others are ignored. ( I had this on laptop, so just used my old include templates) so no big deal.

Issue #3

Again saw on laptop before uploading. If you have headlines with a Picture in them (these are html imbeds via user submitted articles), then when they are additional headlines, the text is truncated at the image point. For example if you look at my FishingNews headlines - this additional headline has this effect

"The Second Springer is Caught on the Blackwater Lodge beats"

Issue #4

(Noticed on laptop, so not used on site)When promoting a thread in forum (normal) - and it has replies in the thread, it creates a read more link that goes to a non-existent pronews story number.

Apart from these minor annoyances all going well so far. Thanks. Now to look in to your related articles stuff...

Cheers

- fishingfan

Issue #1

I've now replaced the old featured content with the FC Home template.

I saw this working perfectly on my laptop test setup, but now on the site it's flickering slightly and the "undefined" is re-appearing.

I deleted my entire sites files and uploaded my test file in zip - so they are identical.

I'll have to take a look/try to recreate.

- fishingfan

Issue #2

If you use your SOC_NET works include on the homepage like I insanely do - the include only appears once. All others are ignored. ( I had this on laptop, so just used my old include templates) so no big deal.

Yes, it seems unavoidable. Smarty INCLUDE seems to be an Include Once function! So only the 1st case gets it. Thus the soc net code will have to be physically present in the HTML, as you now have it. (I didn't put the INCLUDE code into home or hdlines did I?)

- fishingfan

Issue #3

Again saw on laptop before uploading. If you have headlines with a Picture in them (these are html imbeds via user submitted articles), then when they are additional headlines, the text is truncated at the image point. For example if you look at my FishingNews headlines - this additional headline has this effect

"The Second Springer is Caught on the Blackwater Lodge beats"

I'm sure this is the old BBCode straddling the Intro cut off issue. The start img tag gets included but not the closing one. DF BBCode is written to not resolve to the HTML code unless both start and end tags are found, so you see nothing. Only workaround is to put more text in front of the image, or reduce the settings for Intro length, so that the split occurs before the start of the BBCode. Real solution is a routine to smartly chop the Intro text paying full regard to the BBCodes. But I'm rubbish with reg exp

- fishingfan

Issue #4

(Noticed on laptop, so not used on site)When promoting a thread in forum (normal) - and it has replies in the thread, it creates a read more link that goes to a non-existent pronews story number.

Sorry, can't reproduce. Works fine here. Did raise a minor glitch to my notice though - if you have Comments disabled for that Section, then you can't get to see the promoted link. Perhaps I need to override the No Comments setting for existing comments? Dunno how hard that'll be to do though... Effectively No Comments would become No NEW Comments. (Would open the door to comments by admins even when comments turned off, which may not be a bad thing.)

EDIT: Change made for next release: If (and only if) comments already exist then the Comments link is still enabled regardless of Section/Category settings (because user can always go to Forums directly and add comments anyway).

Thanks for the feedback. Glad they are only minor items. Next release is coming along well. Quite a bit there too, for a "finished" product

Thanks

#1 I've made the FContent publically viewable. Seems to be a problem in Firefox.

#2 Don't think so - I just tried to use the include in one of my tempaltes tho.

#3 Thought that may be the case.

#4 Like your comments idea for next release.

Glad to see you're adding more polish to the finished article.

Re #1, problem is in at least FF, Midori & Opera.

To remove the 'undefined' text display please replace line 219 of modules/Pro_News/includes/scripts.js:

	document.getElementById("describediv-"+setting.id).innerHTML=description[setting.currentpage]  // add caption - (c) 2010 layingback: http://layingback.net

with

	if (typeof description[setting.currentpage]=="string") {
		document.getElementById("describediv-"+setting.id).innerHTML=description[setting.currentpage]  // add caption - (c) 2010 layingback: http://layingback.net
	}

As to flickering, I can reproduce but it depends on template/css. If the alternate articles are all of a similar length, and the CSS is set so that the articles just fit, then no flickering is observed. Eg. here on the Home page of this site.

However if 1 of the articles' Intro is long, and the CSS is sized for that long one to fit, then when changing from 1 of the shorter ones, what seems to be happening is that the new entry is drawn initially below the currently item, which subsequently disappears and the new article moves "up". (Probably does this in all cases, but it can't be seen if there is not enough room for anything to appear below.) This looks to be fundamental to the way that the (gecko?) javascript engines display, so I doubt if it can be fixed. Certainly not by me! So workaround may be a simple case of setting the articles to be of similar size, and sizing the height of the FCS to match. Which is most probably the effect that you really want anyway, at least in the general case.

That said, the flicker is obvious if the 'undefined' text is displaying, so removing that may be enough.

Also note that you can adjust the fade in/out rate some by changing the 2nd parameter in the enablefade setting at the end of the template file, from 0.2 to anything in the 0.1 to 0.5 range.

Thanks

That fix worked a treat.

I'll look into the other suggestions later.

And thanks to greenday2k (see post) here's the answer to the include soc_net issue.

The workaround for the INCLUDE is to replace:

<!-- INCLUDE pronews/soc_net.html -->

with

<!-- PHP -->
	# This is a hack since the template system includes files using the include_once() function instead
	# of using the include() function.
	global $cpgtpl;
	$cpgtpl->set_filenames(array('soc_net' => 'pronews/soc_net.html'));
	$cpgtpl->display('soc_net', false);
<!-- ENDPHP -->

Thanks for greenday for the solution and you for pointing it out. Will look to add in to my templates.

Just for grins I submitted a bug report on DF.