SQL Error

Bizzarely, now I have added a few more sections I am getting an SQL error on my home page:

On /~mouygite/dragonfly/index.php
While executing query "SELECT a.id aid, a.* FROM cms_pronews_articles as a JOIN cms_pronews_cats as c ON a.catid=c.id WHERE a.catid= AND a.approved="1" AND a.active="1" AND display<>"0" AND (alanguage='english' OR alanguage='') ORDER BY display_order DESC, posttime DESC LIMIT 5"

the following error occured: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND a.approved="1" AND a.active="1" AND display<>"0" AND (alanguage='english' OR' at line 1

In: /home/mouygite/public_html/dragonfly/modules/Pro_News/functions.php on line: 2022

Interestingly enough when I look at the SQL queries on the page it shows the a.catid as being set?

0.0001 - LINE 2022: SELECT a.id aid, a.* FROM cms_pronews_articles as a JOIN cms_pronews_cats as c ON a.catid=c.id WHERE a.catid=3 AND a.approved="1" AND a.active="1" AND display<>"0" AND (alanguage='english' OR alanguage='') ORDER BY display_order DESC, posttime DESC LIMIT 5

Now I've added some categories to the sections that error has gone away. Is that normal?

If you can easily repeat - say by adding a new Section without a Category - and do whatever you were doing to trigger the error, can you test if this fixes it please?

Around line 1945 look for:

        if ($pnsettings['display_by'] == '2') {
            $sql .= ' LEFT JOIN '.$prefix.'_pronews_cats as c ON c.sid=s.id AND secdsplyby<>"1"';
        } else {
            $sql .= ' LEFT JOIN '.$prefix.'_pronews_cats as c ON c.sid=s.id AND secdsplyby="2"';
        }

and then remove the 2 words LEFT.

I think I'm returning Sections without Categories and thus getting errors when the newer display modes (List by Section/Category/Articles) does a selection based on Category value. Hopefully this will just ignore them.

TIA.

Will do - may not be for a day or two as real work intervenes again!

S'Ok, I managed to reproduce, and fix works ok, and doesn't appear to have any unwanted effects, so moving to release.