Link to CPGNuCalendar problem

Hmm, interesting.. It's just done the link correctly using admin submit. Odd thing is doing non-admin submit it's changed 1400-1800 into 1600-2000 so a two hour shift...

(and found another time where & characters need to be allowed for - I'll post on the other thread)

Well that's useful info! Probably means just a typo in functions.php, or missed/messed up update. I'm sure user-side Calendar links haven't been used much. But I'm getting hungry...

OK, found some differences between the 2 routines - looks as if last set of changes to admin_functions was not migrated across to functions.

So please in functions.php try replacing the entire create_cal routine with the one in the attached txt file.

(The routines are not identical in their calls and access privileges, so you can't just copy from admin into functions.)

OK...

This is all for non-admin submit.

It is still adding 2 hours to the entry - 1400-1800 becomes 1600-2000.

If you edit the original story the boxes on the edit page subsequently become 1800-2200. And then the edit routine adds the amp; bit to the title when it changes the calendar entry...

OK, I *may* have got this working (although I'm worried that as I'm on GMT I may be special case ...) And it looks to be patchable.

For admin_functions.php only, make the following edits:

Find at the bottom of function dttime_edit

        $content .= ($gmttime == 0) ? '' : ' <span class="pn_tiny">GMT'.((($userinfo['user_timezone']+L10NTime::in_dst($gmttime, $userinfo['user_dst'])) >= 0) ? '+' : '-').($userinfo['user_timezone']+L10NTime::in_dst($gmttime, $userinfo['user_dst']))._PNHRS.'</span>';
        $content .= ' <span class="pn_tinygrey">';
        $content .= ($hropt) ? '('._PNOPTIONAL.')' : '';
        $content .= '</span>';

and replace with

        $content .= ' '._PNGMT.((($userinfo['user_timezone']+L10NTime::in_dst(($gmttime == 0 ? time() : $gmttime), $userinfo['user_dst'])) >= 0) ? '+' : '').($userinfo['user_timezone']+L10NTime::in_dst(($gmttime == 0 ? time() : $gmttime), $userinfo['user_dst']))._PNHRS.' &nbsp; <span class="pn_tinygrey">';
        $content .= ($hropt) ? '('._PNOPTIONAL.')</span>' : '</span>';

In function create_cal find these 2 lines

        $startday = mktime(0, 0, 0, ProNewsAdm::pndate('m', $clsdttime, $userinfo['user_dst'], $userinfo['user_timezone']), ProNewsAdm::pndate('d', $clsdttime, $userinfo['user_dst'], $userinfo['user_timezone']), ProNewsAdm::pndate('Y', $clsdttime, $userinfo['user_dst'], $userinfo['user_timezone']));

            $endday = mktime(0, 0, 0, ProNewsAdm::pndate('m', $cledttime, $userinfo['user_dst'], $userinfo['user_timezone']), ProNewsAdm::pndate('d', $cledttime, $userinfo['user_dst'], $userinfo['user_timezone']), ProNewsAdm::pndate('Y', $cledttime, $userinfo['user_dst'], $userinfo['user_timezone']));

and change all the calls to ProNewsAdm::pndate in each to just date (ie delete 'ProNewsAdm::pn').

and find

        $clstime = ($clstime == -1) ? -1 : formatDateTime($clsdttime,'%H%M').'00';
        $sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("", "'.$postby.'", "'.formatDateTime($clsdttime,'%Y%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%Y%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.$title.'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';

and replace with

        $clstime = ($clstime == -1) ? -1 : formatDateTime($clsdttime,'%H%M').'00';
        $sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("", "'.$postby.'", "'.formatDateTime($clsdttime,'%Y%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%Y%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.$title.'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';

Last line should also clean up the & in title issue.

The first edit above is just to display your current tz a la user side.

Remaining edits are to address the 3 interrelated issues - dsl subtracted not added as I suspected, no longer any need for my own date routine, and finally compensating for CPGNC not handling dst.

Should be easy to migrate to user side if you wish.

Please note that the above is for INSERT ONLY - more changes are required for update, etc. But this should handle 90+% of cases.

Hmm, that didn't work. Nothing went into the calendar at all (from looking at the database) and when you go to edit the article the date entry is all wrong.

I entered 17 Oct 10 1400 - 1800 and in the edit it is showing as 17 Mar 07 1930 - 2130!

There's also now an undefined language entry of _PNGMT. (although it now correctly shows as GMT+2 for my setting)

Just tried doing exactly the same - still no entry in the CPGNuCalendar table and if I look to edit the same article with the same dates initially entered it is now showing the calendar entry as 31 Mar 07 1200-1900!

PHP debug info on the admin page also shows

modules/Pro_News/admin/admin_functions.php
Notice line 118: Undefined variable: sqlcount
Notice line 216: Undefined variable: is_home

You can address the language entry by adding:

define('_PNGMT','GMT');        //Greenwich Mean Time / UTC Coordinated Universal Time

The Notices don't matter (Notices never do) and in this case are immaterial because they are from the Admin Articles display (to see errors from the Submit Article screen you need to comment out the url redirect to the Admin Articles screen).

The saved article will get its times from the Calendar, but I don't understand why you have no visible entry in Calendar... Hmmm.

EDIT: Both Notices now addressed (in next release).

OK, just wondered if the notices were relevant to the problem... Do you want me to comment out the redirect to see the SQL etc?

Please. Look for

    // -- Submit mode

in admin_article function, and comment out the first url redirect after that - about 27 lines later - the one following the INSERT INTO's. Also please remove the // in front of all 2 echo lines in the create_cal function.

Then submit a NEW article. Article will post, and update Calendar (or try to) but will display 3 echo lines rather than switching to Admin display. Please post those 3 lines here. (Start and end times in Epoch, start time in DDMMYYYY, duration in mins, approved in DDMMYYY.)

This for an article submitted with a link to an event on 10/10/2010 1400-1800.

startday=943920000 endday=943920000 s time=1286712000 e time=1286726400 clstime= calduration=240

I added a couple of echos for the cal approved one and sql and got this:

startday=943920000 endday=943920000 s time=1286712000 e time=1286726400 clstime= calduration=240 cal_appvd=20101009

sql=INSERT INTO chantill_cpgnucalendar VALUES ("", "webmaster", "20101010", "140000", "20101009", "145105", "240", "2", "E", "0", "Testing", "Please ignore Click to follow Link to Originating Article.", "circle.gif", "20101009", "1")

Nothing was added to the cpgnucalendar table. Turning on warnings I got this - not sure if relevant:

modules/Pro_News/admin/admin_functions.php
Warning line 2810: date() expects at most 2 parameters, 4 given
Warning line 2810: date() expects at most 2 parameters, 4 given
Warning line 2810: date() expects at most 2 parameters, 4 given
Warning line 2814: date() expects at most 2 parameters, 4 given
Warning line 2814: date() expects at most 2 parameters, 4 given
Warning line 2814: date() expects at most 2 parameters, 4 given

So near and yet so far!

I'm confused. The SQL line looks fine, yet it didn't take? You aren't using MySQL5 in STRICT mode are you? That would need a 0 in the first field (in place of null) - but that should give an SQL error.

I just pasted that SQL line into MyPhpAdmin and it took. Just changed the db prefix and added the 0 - because I run in STRICT now so that I hit the issues before anyone else.

The date and times look correct. So if we could find the cause of it not saving to the db, we'd be done. Besides the update code, and the port to user side, and the read back error for subsequent updates, and ...

The warning for date is because my pndate had extra parameters, need to remove the extras, but for now they should just be ignored...

Very odd - have just tried the sql in phpmyadmin and it entered it fine (so don't appear to be in strict mode). Going to have another go with it after lunch...

Just tried again - it still isn't adding anything to the cpgnucalendar table... very odd. Just checked the non-admin submit and that does add an entry (albeit wrong!)

You are creating a new article (and event) aren't you? (I haven't patched the edit function as yet.)