Links problem

I have an article that I use as a menu for various sections, putting it topmost and not to display in home. It has been working fine but I've just noticed it is no longer working. You can see it as the topmost article here. The source is this

[img]images/arrow.gif[/img][url=Content_4/pid=10.html] Cricket Home Page[/url]
[img]images/arrow.gif[/img] [url=Pro_News/cid=10.html]Cricket News[/url]
[img]images/arrow.gif[/img][url=Forums/viewforum/f=26.html] Cricket Chat[/url]
[img]images/arrow.gif[/img][url=Downloads/c=9.html] Downloads[/url]
[img]images/arrow.gif[/img] [url=Pro_News/cid=13.html]Match Reports 2009[/url]
[img]images/arrow.gif[/img] [url=coppermine/cat=6.html]Gallery[/url]

The coppermine link works but all the others don't all of a sudden.

Ideally I'd like to be able to use a block here but not sure how i could do that when I need to link to forums, articles and gallerys etc...

Well if you roll your mouse over the links in a real browser, you'll see the links displayed in the status bar, and all but the coppermine one have \" around the active (non-BASEREF) part of the url.

Alternatively click on the link and study the url in the browser's location bar after you get the 403.

As to why this suddenly occurred, did you have a browser which was able to handle this before and which has now been updated to a more standards compliant version?

To your other question, of course you can use a block here, make it the most recent, or oldest, or only article in a Section, and select that Section to display just 1 record in a Center Block. All from within Pro_News. Can't see how where the links link to would make any difference to Pro_News - block or no block.

And if you don't mind me saying, I would precede the links with enough blank lines to either center it vertically on the main image, or align the last with the bottom of the image to get them clear of the Category icon (cricket ball).

I haven't updated any browser for a while - I notice the links are wrong with other browsers too. From the code I can't see where the extra \'s are coming from - the link code is the same for the forum as it is for coppermine - so I can only assume PN is adding them for some reason?

I don't see how Pro_News could do it, as it treats the Intro (and Content) as single blocks. More likely a nbbcode.php problem.

If you look at the source for the page everything, link, title, even CSS class are double quoted, or rather have "\" in place of ".

But lets first establish if it is a current problem, or something which happened in the past.

Can you create a new Pro_News article and copy and paste the content between the 2 Submit screens, such that you have a perfect duplicate, and see if the error appears in the new one, please.

If it doesn't we have some historical event - (issue when applying patch to nbbcode.php?). If it replicates the problem then further investigation will be required.

Can you remember if the coppermine link was added later, or the others where edited when the coppermine one was not?

I've just resubmitted it again, using the same code as shown above, and exactly the same thing happens. The coppermine link was added, on both occasions, at the same time.

See the Submitted article for approval on your site to see what my test revealed.

There is a non-printable character there causing the issue I think. However same block of text does not cause this problem on my site, so I think your nbbcode.php has some issue too.

Will email you a copy of my (9.2.1 compatible) version to try.

Hmm, my version of nbbcode was

$Revision: 9.46.2.4 $
$Author: phoenix $
$Date: 2008/10/29 01:36:44 $

but I've replaced it with yours (which seems to have all the table stuff etc still in there!) and it seems to have fixed the problem! I knew it wouldn't be Pro_News you see!

Am surprised that it changes the way the article is displayed rather than just a save time - but then that shows how much I understand how these things work!

Thanks for sorting it...

Glad it's sorted, but can I ask you to quickly double check your corrupt version against my latest patch instructions for nbbcode please? I'm concerned as to whether the error was on your part or built into my instructions. Thanks.

I also noticed your modified modules/Pro_News/search.inc - can I get a copy please? It might make sense to include as an option: combined or broken out by Section. (Not this release though )

I don't think it was any of your edits, it is possibly that we just started from different original files. The main differences seem to be that in my original I had

		# Fix linebreaks on important items
		$text = preg_replace('#<br>#si', '<br />', $text);
		$text = preg_replace('#<ul><br \/>#si', '<ul>', $text);
		$text = preg_replace('#<\/ul><br \/>#si', '</ul>', $text);
		$text = preg_replace('#<\/ol><br \/>#si', '</ol>', $text);
		$text = preg_replace('#<\/table><br \/>#si', '</table>', $text);
		$text = preg_replace('#<\/div><br \/>#si', '</div>', $text);
		$text = preg_replace('#<br \/><table#si', '<table', $text);

which is different to yours and I didn't have

			} elseif  ($part['code'] == 'table') {															// remove all embedded newlines layingback
				$text .= nl2br(BBCode::encode_html(preg_replace('/[\n|\r]*/si', '', $part['text'])));		// !!! could be improved to leave newlines in [th] and [td]
		

I am unaware that I've changed anything in search.inc - this is it:

 [ actual code removed - it was the same - lb ]

Thanks I understand the search issue now. Has given me an idea though ...

Yes, I started from v9.60 - EDIT: sorry 9.46 - although nano has produced 9.46.2.5 as recently as a week ago. Are you running 9.2.3.3?

(The 2nd change you noticed was my fix for the blank lines left in rendered tables. It was the 2st difference that was causing the issue I think.)

BTW, did you have the same problems with the original unmodified nbbcode.php?

I've only just noticed the error - it seemed to work fine before so not sure when the error appeared. I'm still on 9.2.1 as I daren't upgrade just yet! I've made so many changes files that I'm concerned how long it'll take to repair them all (mostly coppermine stuff putting the user on event links in).

I was going to ask how I might add the nbbcode stuff into other modules (Classified specifically) , but I'll do that on DF for greater coverage..

Yes, it does look as if a bug crept into CVS versions.

The copy I sent is based on v9.46 from original 9.2.1 release, but includes my latest enhancements to my fixes, so that you can use www.teamopolis.com/too...rator.aspx to build your tables. (Previously their formated layout produced blank lines before your table in Pro_News.)

I don't understand your question about including in Classifieds. As you patched nbbcode it should apply to any and all modules which use nbbcode. Ah .. I see ... Classifieds doesn't have nbbcode! Well, let me put it this way: I think it might be less work to make a template for Pro_News to mimic Classifieds than it would be to add nbbcode to Classifieds.