The '&' character

When I submit an article with the '&' character in the title pro_news changes it to &. If I edit it it becomes '&' Within the edit page I can remove the extra bits and it saves & properly. Very odd!

I'm not understanding. It should appear as & in edit page and in display, but be stored internally as & so that it doesn't generate XHTML validation errors.

Which submit article (admin or user)? Which field or fields? And which template? Which Pro_News version?

The forum stripped some of the characters!

It should have said

When I submit an article with the '&' character in the title pro_news changes it to &. If I edit it it becomes '&' Within the edit page I can remove the extra bits and it saves & properly. Very odd!

This is using admin submit in the title field. Using index3fcs.html. Pro_news 3.3.2.0 at the moment..

Try this, please.

In admin_functions.php (around line 2496) find:

                'T_TITLE' => '<input type="text" name="title" size="50" value="'.htmlprepare($edit['title']).'" />',

and replace with:

                'T_TITLE' => '<input type="text" name="title" size="50" value="'.$edit['title'].'" />',

ie. remove the htmlprepare call.

Similarly, in functions.php (around line 1516) find:

                'T_TITLE' => '<input type="text" name="title" size="50" value="'.htmlprepare($edit['title']).'" />',

and replace with:

                'T_TITLE' => '<input type="text" name="title" size="50" value="'.$edit['title'].'" />',

ie. remove the htmlprepare call.

If that works - and it seems to here - then this bug has always been in Pro_News! Although it may not have always shown up. It only affects the edit display, so no serious DB harm should have ever occurred from this one, although some double amp;amp;'s may have crept in over time.

Will do.. I only noticed it when trying the & character for the first time.

Seems to work perfectly. You always worry me when my line numbers are so different from yours - it was lines 2469 and 1490 for me!

Shall I change the topic title here to solved?

Please do on the title change.

Reason for numbers being off, and why I said "around" is that I'm working with 3.2.2.1. Which I thought was ready!

BTW, seen this post yet?

Looks as if I'll have to do a new release. It used to be a 10 minute job, plus checking, but now takes hours due to all the "extras" added/moved over time.

One other time (there may be more?) when the title contains an & and you link to CPGNuCalendar it is adding the amp: to it.

Nope, can't reproduce. Can you give me more specifics please?

I did find a db error when using MySQL 5 in Strict mode though. Simple fix for that one.

NEVER MIND: I see - in the Calendar.

Hmmm. That has to be a CPGNuCalendar bug, 'cos the browser is displaying the tooltip correctly. So CPGNC is handling the 2 displays (from the same source) differently.

OK, CPGNC presumes that it will receive just a &. So in admin_functions.php around (before) line 2863 find:

        $sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("", "'.$postby.'", "'.formatDateTime($clsdttime,'%Y%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%Y%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.$title.'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';

and change to:

        $sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("0", "'.$postby.'", "'.formatDateTime($clsdttime,'%Y%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%Y%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.htmlunprepare($title).'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';

Similarly in functions.php (~ 4536) find:

        $sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("", "'.$postby.'", "'.formatDateTime($clsdttime,'%G%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%G%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.$title.'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';

and replace with:

        $sql = 'INSERT INTO '.$prefix.'_cpgnucalendar VALUES ("0", "'.$postby.'", "'.formatDateTime($clsdttime,'%G%m%d').'", "'.$clstime.'", "'.formatDateTime(time(),'%G%m%d').'", "'.formatDateTime(time(),'%H%M%S').'", "'.$cal_durtn.'", "'.$cal_priority.'", "'.$cal_rpt.'", "'.$cal_view.'", "'.htmlunprepare($title).'", "'.$cal_content.'", "'.$cal_image.'", "'.$cal_appvd.'", "'.$cal_category.'")';

(The 0 added to the first parameter is to address the MySQL5 Strict issue.)

That seems to work, thank you!